-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3 - User Authentication #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please resolve conflicts
- Please change pr title - we have a rule that pr title should look like this:
#issue-number - title
So in this case, we should give title like
#3 - user auth
And also please remember that in pr description we should write down every issue that is connected with pr or any issues that should bo closed after merging this pr. Something like: This should close #issue-number
- Please don't push
.env
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are failed - please fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please fix all warnings from GitHub - like this
- At our company, we avoid leaving comments in the code unless absolutely necessary. We believe that code should be self-explanatory. That said, if you really feel a comment is needed, don’t worry—we can live with it. 😄 Let’s just keep it to a minimum.
I know that most of comments are from Laravel Breeze and fresh Laravel installation, but I think we can remove them
-
I think that tasks User login #4 and Password reset feature #5 can be closed because in Laravel Breeze out of the box we have features like login to application and reset password
-
For me reset password doesn't work, i got an error like
The "" scheme is not supported; supported schemes for mailer "smtp" are: "smtp", "smtps".
I read that is problem with some composer dependency, so if you have the same problem, run composer require "symfony/mailer:~7.1.0"
and push this - it should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Check is failed - please run
make fix
- it should fix all errors - Extra blank lines have been unnecessarily added at the end of the file, resulting in two blank lines. This clutters the code and doesn't follow standard formatting practices. Please keep only one blank line at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented user authentication using Laravel Breeze.
Integrated login and registration functionality.
Resolved conflicts with the authentication code.
Connected the authentication features with the Vue.js and Inertia.js front end.
This should close #3
This should close #4
This should close #5